Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Plugwise climate issues for new firmware #32080 #32109

Merged
merged 2 commits into from Feb 23, 2020

Conversation

@CoMPaTech
Copy link
Contributor

CoMPaTech commented Feb 23, 2020

Proposed change

Bump Haanna to 0.14.3, fixing the reported Home Assistant issue:
fixes #32080

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

Unchanged

Additional information

  • This PR fixes or closes issue: fixes #32080
  • This PR is related to issue: #32080
  • Link to documentation pull request: n/a

Firmware changed timestamp format - python module was updated accordingly to handle this, bumped version of the requirement accordingly.

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

  • Documentation added/updated for [www.home-assistant.io][docs-repository]

If the code communicates with devices, web services, or third-party tools:

  • The [manifest file][manifest-docs] has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following [Integration Quality Scale][quality-scale]:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum
@probot-home-assistant

This comment has been minimized.

Copy link

probot-home-assistant bot commented Feb 23, 2020

Hey there @laetificat, @bouwew, mind taking a look at this pull request as its been labeled with a integration (plugwise) you are listed as a codeowner for? Thanks!

@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Feb 23, 2020
@CoMPaTech CoMPaTech changed the title Plugwise version bump 32080 Fix Plugwise climate issues for new firmware #32080 Feb 23, 2020
@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 23, 2020

Codecov Report

Merging #32109 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev   #32109   +/-   ##
=======================================
  Coverage   94.72%   94.72%           
=======================================
  Files         767      767           
  Lines       55486    55486           
=======================================
  Hits        52560    52560           
  Misses       2926     2926

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update f975654...f426c0d. Read the comment docs.

@bouwew

This comment has been minimized.

Copy link
Contributor

bouwew commented Feb 23, 2020

Tested and working on my system.

@Mariusthvdb

This comment has been minimized.

Copy link
Contributor

Mariusthvdb commented Feb 23, 2020

+1 tested and working nicely on 105.5 and 106b1

Copy link
Member

springstan left a comment

Should we include this in the beta?

Dev automation moved this from By Code Owner to Reviewer approved Feb 23, 2020
@CoMPaTech

This comment has been minimized.

Copy link
Contributor Author

CoMPaTech commented Feb 23, 2020

@springstan that looks like the best way to get it to the users of the integration when their devices upgrade to the new version, unless the gates are closed on 106

@springstan springstan added this to the 0.106.0 milestone Feb 23, 2020
@springstan

This comment has been minimized.

Copy link
Member

springstan commented Feb 23, 2020

@CoMPaTech nope still open :)

@CoMPaTech

This comment has been minimized.

Copy link
Contributor Author

CoMPaTech commented Feb 23, 2020

Tnx!

@springstan springstan merged commit d22ee71 into home-assistant:dev Feb 23, 2020
11 checks passed
11 checks passed
CI Build #20200223.26 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing f975654...f426c0d
Details
codecov/project 94.72% remains the same compared to f975654
Details
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Feb 23, 2020
@lock lock bot locked and limited conversation to collaborators Feb 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Linked issues

Successfully merging this pull request may close these issues.

6 participants
You can鈥檛 perform that action at this time.