Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add homekit_controller occupancy sensor #32188

Merged
merged 1 commit into from Feb 25, 2020

Conversation

@Jc2k
Copy link
Contributor

Jc2k commented Feb 25, 2020

Proposed change

This implements the occupancy sensor type requested in #31827 for homekit accessories.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #31827
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum
@project-bot project-bot bot added this to Needs review in Dev Feb 25, 2020
@Jc2k Jc2k changed the title Add occupancy sensor Add homekit_controller occupancy sensor Feb 25, 2020
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Feb 25, 2020
@Jc2k Jc2k mentioned this pull request Feb 25, 2020
3 of 7 tasks complete
@Jc2k

This comment has been minimized.

Copy link
Contributor Author

Jc2k commented Feb 25, 2020

Copy link
Member

MartinHjelmare left a comment

Looks good!

Dev automation moved this from By Code Owner to Reviewer approved Feb 25, 2020
@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 25, 2020

Codecov Report

Merging #32188 into dev will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev   #32188   +/-   ##
=======================================
  Coverage   94.74%   94.74%           
=======================================
  Files         772      772           
  Lines       55861    55885   +24     
=======================================
+ Hits        52928    52951   +23     
- Misses       2933     2934    +1     
Impacted Files Coverage 螖
homeassistant/helpers/entity.py 97.30% <0.00%> (-0.34%) 猬囷笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update dd13e99...0a8c37f. Read the comment docs.

@Jc2k Jc2k merged commit 4a89fba into home-assistant:dev Feb 25, 2020
11 checks passed
11 checks passed
CI Build #20200225.133 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch 100.00% of diff hit (target 94.74%)
Details
codecov/project 94.74% (target 90.00%)
Details
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Feb 25, 2020
@Jc2k Jc2k deleted the Jc2k:homekit_controller_occ_sensor branch Feb 25, 2020
zhulik added a commit to zhulik/home-assistant that referenced this pull request Feb 26, 2020
@lock lock bot locked and limited conversation to collaborators Feb 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can鈥檛 perform that action at this time.