Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error where SimpliSafe websocket would disconnect and not reconnect #32199

Merged
merged 2 commits into from Feb 26, 2020

Conversation

@bachya
Copy link
Contributor

bachya commented Feb 26, 2020

Proposed change

This PR fixes an unhandled SimpliSafe exception.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml
simplisafe:
  accounts:
    - username: !secret simplisafe_username
       password: !secret simplisafe_password

Additional information

  • This PR fixes or closes issue: fixes #32198
  • This PR is related to issue: N/A
  • Link to documentation pull request: N/A

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum
@bachya bachya self-assigned this Feb 26, 2020
@project-bot project-bot bot added this to Needs review in Dev Feb 26, 2020
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Feb 26, 2020
@bachya bachya added this to the 0.106.0 milestone Feb 26, 2020
@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 26, 2020

Codecov Report

Merging #32199 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev   #32199   +/-   ##
=======================================
  Coverage   94.75%   94.75%           
=======================================
  Files         772      772           
  Lines       55885    55885           
=======================================
  Hits        52952    52952           
  Misses       2933     2933

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update b5c1afc...7ce20e9. Read the comment docs.

Copy link
Member

pvizeli left a comment

Like the function name said above _dirty. The error handling is bad and the library should handle this better with a reconnect after the WebSocket ping fails and doesn't need such ugly code in the layer above the API. I would like if you can make a robust WebSocket handling on the library and clean up the code on HA.

Dev automation moved this from By Code Owner to Reviewer approved Feb 26, 2020
@pvizeli pvizeli merged commit e435f6e into home-assistant:dev Feb 26, 2020
10 checks passed
10 checks passed
CI Build #20200226.33 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing b5c1afc...7ce20e9
Details
codecov/project 94.75% remains the same compared to b5c1afc
Details
Dev automation moved this from Reviewer approved to Done Feb 26, 2020
frenck added a commit that referenced this pull request Feb 26, 2020
鈥t (#32199)

* Fix error where SimpliSafe websocket would disconnect and not reconnect

* Await
@bachya bachya deleted the bachya:ss-socket-check branch Feb 26, 2020
@bachya bachya mentioned this pull request Feb 26, 2020
9 of 20 tasks complete
@lock lock bot locked and limited conversation to collaborators Feb 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can鈥檛 perform that action at this time.