Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sms support to pushbullet notification #32347

Merged
merged 5 commits into from Mar 1, 2020

Conversation

@doudz
Copy link
Contributor

doudz commented Feb 29, 2020

Proposed change

Add sms support to pushbullet notification

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum
doudz added 3 commits Feb 29, 2020
@MartinHjelmare MartinHjelmare changed the title add sms support to pushbullet notification Add sms support to pushbullet notification Feb 29, 2020
@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 29, 2020

Codecov Report

Merging #32347 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev   #32347   +/-   ##
=======================================
  Coverage   94.75%   94.75%           
=======================================
  Files         775      775           
  Lines       56171    56171           
=======================================
  Hits        53225    53225           
  Misses       2946     2946

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 3ab0411...b785a3c. Read the comment docs.

@doudz doudz mentioned this pull request Feb 29, 2020
3 of 7 tasks complete
Copy link
Member

Danielhiversen left a comment

Nice

Dev automation moved this from Needs review to Reviewer approved Mar 1, 2020
@Danielhiversen Danielhiversen merged commit 7a7fdc5 into home-assistant:dev Mar 1, 2020
10 checks passed
10 checks passed
CI Build #20200229.45 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 3ab0411...b785a3c
Details
codecov/project 94.75% remains the same compared to 3ab0411
Details
Dev automation moved this from Reviewer approved to Done Mar 1, 2020
@lock lock bot locked and limited conversation to collaborators Mar 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can鈥檛 perform that action at this time.