Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report entity IDs for min/max sensor platform #33806

Merged
merged 2 commits into from May 25, 2020

Conversation

Tho85
Copy link
Contributor

@Tho85 Tho85 commented Apr 7, 2020

Proposed change

Currently, the min/max platform only reports the actual minimum, maximum and last values for the configured entity. With this change, it also reports the corresponding entity IDs (min_entity_id, max_entity_id, last_entity_id)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

@project-bot project-bot bot added this to Needs review in Dev Apr 7, 2020
@probot-home-assistant
Copy link

Hey there @fabaff, mind taking a look at this pull request as its been labeled with a integration (min_max) you are listed as a codeowner for? Thanks!

@stale
Copy link

stale bot commented May 7, 2020

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

@stale stale bot added the stale label May 7, 2020
@Tho85
Copy link
Contributor Author

Tho85 commented May 10, 2020

Hey @fabaff, any chance you could have a look at this before it gets closed?

@stale stale bot removed the stale label May 10, 2020
homeassistant/components/min_max/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/min_max/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/min_max/sensor.py Outdated Show resolved Hide resolved
Dev automation moved this from Needs review to Review in progress May 17, 2020
@Tho85 Tho85 requested a review from MartinHjelmare May 17, 2020 20:59
Dev automation moved this from Review in progress to Reviewer approved May 17, 2020
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@cgarwood cgarwood merged commit fa55f01 into home-assistant:dev May 25, 2020
Dev automation moved this from Reviewer approved to Done May 25, 2020
kennedyshead pushed a commit to kennedyshead/home-assistant that referenced this pull request May 28, 2020
* Report entity ids for min/max sensor platform

* Use better variable names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants