Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

UniFi - Roaming clients should be considered connected #33942

Merged

Conversation

Kane610
Copy link
Member

@Kane610 Kane610 commented Apr 10, 2020

Breaking change

Proposed change

Consider roaming clients as home as well.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

@Kane610 Kane610 self-assigned this Apr 10, 2020
@probot-home-assistant probot-home-assistant bot added integration: unifi small-pr PRs with less than 30 lines. labels Apr 10, 2020
@project-bot project-bot bot added this to Needs review in Dev Apr 10, 2020
Dev automation moved this from Needs review to Reviewer approved Apr 10, 2020
Copy link
Member

@springstan springstan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 馃憤

@Kane610 Kane610 merged commit bc03635 into home-assistant:dev Apr 10, 2020
Dev automation moved this from Reviewer approved to Done Apr 10, 2020
@Kane610 Kane610 deleted the unifi-improve_wireless_connection_status branch April 10, 2020 13:43
@lock lock bot locked and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

Unifi Integration: Clients stuck Away
3 participants