Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

UniFi - Allow tracking of clients connected to third party APs #34067

Conversation

Kane610
Copy link
Member

@Kane610 Kane610 commented Apr 11, 2020

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

@Kane610 Kane610 self-assigned this Apr 11, 2020
@project-bot project-bot bot added this to Needs review in Dev Apr 11, 2020
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Apr 12, 2020
@Kane610 Kane610 force-pushed the unifi-disable_network_media_logic_client_tracker branch from 5aead7f to 2296462 Compare April 12, 2020 13:06
@Kane610 Kane610 marked this pull request as ready for review April 12, 2020 22:30
@Kane610 Kane610 force-pushed the unifi-disable_network_media_logic_client_tracker branch from c23af5b to 02b3356 Compare April 13, 2020 19:14
Dev automation moved this from By Code Owner to Reviewer approved Apr 16, 2020
@Kane610 Kane610 merged commit 465eeab into home-assistant:dev Apr 17, 2020
Dev automation moved this from Reviewer approved to Done Apr 17, 2020
@Kane610 Kane610 deleted the unifi-disable_network_media_logic_client_tracker branch April 17, 2020 06:39
@lock lock bot locked and limited conversation to collaborators Apr 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

Unifi - presence detection stops working if wired clients are listed in unifi_data
3 participants