Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade broadlink lib to 0.13.1 #34290

Merged
merged 1 commit into from Apr 16, 2020
Merged

Upgrade broadlink lib to 0.13.1 #34290

merged 1 commit into from Apr 16, 2020

Conversation

Danielhiversen
Copy link
Member

Breaking change

Proposed change

Upgrade broadlink lib to 0.13.1
https://github.com/mjg59/python-broadlink/commits/master

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

@probot-home-assistant
Copy link

Hey there @Danielhiversen, @felipediel, mind taking a look at this pull request as its been labeled with a integration (broadlink) you are listed as a codeowner for? Thanks!

Dev automation moved this from Needs review to Reviewer approved Apr 16, 2020
@MartinHjelmare MartinHjelmare merged commit 2f415b0 into dev Apr 16, 2020
Dev automation moved this from Reviewer approved to Done Apr 16, 2020
@delete-merged-branch delete-merged-branch bot deleted the broadlink_lib branch April 16, 2020 18:51
@MartinHjelmare MartinHjelmare added this to the 0.108.6 milestone Apr 16, 2020
balloob pushed a commit that referenced this pull request Apr 17, 2020
@balloob balloob mentioned this pull request Apr 17, 2020
auchter pushed a commit to auchter/home-assistant that referenced this pull request Apr 18, 2020
@lock lock bot locked and limited conversation to collaborators Apr 19, 2020
@balloob balloob added the bugfix label May 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

Broadlink out of order since upgrade to 0.108.0
5 participants