Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UniFi - Improve creating client trackers on startup affected by SSID filter #34509

Conversation

Kane610
Copy link
Member

@Kane610 Kane610 commented Apr 21, 2020

Breaking change

Proposed change

Only match SSID filter if SSID is present, this will only affect recently disconnected clients and clients which have a previously created entry in entity registry

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

…ntly disconnected clients and clients which have a previously created entry in entity registry
@Kane610 Kane610 self-assigned this Apr 21, 2020
@project-bot project-bot bot added this to Needs review in Dev Apr 21, 2020
@Kane610 Kane610 merged commit 867138e into home-assistant:dev Apr 21, 2020
Dev automation moved this from Needs review to Done Apr 21, 2020
@Kane610 Kane610 deleted the unifi-improve_tracked_clients_available_on_start branch April 21, 2020 19:13
@lock lock bot locked and limited conversation to collaborators Apr 25, 2020
@balloob balloob added the bugfix label May 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

Unifi device trackers unavailable in 0.108
3 participants