Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rokuecp to 0.3.2 #35429

Merged
merged 2 commits into from May 9, 2020
Merged

Update rokuecp to 0.3.2 #35429

merged 2 commits into from May 9, 2020

Conversation

ctalkington
Copy link
Contributor

Breaking change

Proposed change

This fixes the media image pointing to a non-existing image. This also reduces request overhead by only querying the list of TV channels once on initial update from device since we don't even currently use the full TV channel list in HA (hint hint future update :))

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

@project-bot project-bot bot added this to Needs review in Dev May 9, 2020
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev May 9, 2020
@ctalkington ctalkington changed the title Update rokuecp to 0.3.1 Update rokuecp to 0.3.2 May 9, 2020
@ctalkington ctalkington merged commit 96d2b8c into dev May 9, 2020
Dev automation moved this from By Code Owner to Done May 9, 2020
@delete-merged-branch delete-merged-branch bot deleted the ctalkington-rokuecp-031 branch May 9, 2020 21:26
@lock lock bot locked and limited conversation to collaborators May 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants