Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add const module to oauth2 scaffold template #35438

Merged
merged 3 commits into from May 10, 2020

Conversation

MartinHjelmare
Copy link
Member

@MartinHjelmare MartinHjelmare commented May 10, 2020

Breaking change

Proposed change

  • The const module was missing in the oauth2 template.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

@probot-home-assistant probot-home-assistant bot added the small-pr PRs with less than 30 lines. label May 10, 2020
@project-bot project-bot bot added this to Needs review in Dev May 10, 2020
@MartinHjelmare MartinHjelmare changed the title Add const module to oauth2 template Add const module to oauth2 scaffold template May 10, 2020
Dev automation moved this from Needs review to Reviewer approved May 10, 2020
@bdraco
Copy link
Member

bdraco commented May 10, 2020

Testing

File homeassistant/components/august/const.py already exists, creating EXAMPLE_const.py instead.
Writing homeassistant/components/august/EXAMPLE_const.py

Verified existing const.py was not overwritten

@MartinHjelmare MartinHjelmare merged commit b4142fc into dev May 10, 2020
Dev automation moved this from Reviewer approved to Done May 10, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix-oauth-scaffold-const branch May 10, 2020 10:10
@lock lock bot locked and limited conversation to collaborators May 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed small-pr PRs with less than 30 lines.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants