Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pydaikin to 2.0.1, catch HTTPForbidden exception #35466

Merged
merged 2 commits into from May 11, 2020

Conversation

fredrike
Copy link
Contributor

@fredrike fredrike commented May 10, 2020

Proposed change

Catch HTTPForbidden thrown when authentication in init() is unsuccessful.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

@project-bot project-bot bot added this to Needs review in Dev May 10, 2020
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev May 10, 2020
@fredrike fredrike changed the title Bump pydaikin to 2.0.1, catch Forbidden exception Bump pydaikin to 2.0.1, catch HTTPForbidden exception May 10, 2020
@ctalkington
Copy link
Contributor

#34523 introduced some common strings such as invalid_auth that are shared between all integrations that choose to use them. I wonder if thats better to use here also is there a reason to abort when it may be user correctable if you provided error feedback?

@fredrike
Copy link
Contributor Author

#34523 introduced some common strings such as invalid_auth that are shared between all integrations that choose to use them. I wonder if thats better to use here also is there a reason to abort when it may be user correctable if you provided error feedback?

Yes you are right, I will change it to use common strings,what is the best way to show the error?

Dev automation moved this from By Code Owner to Reviewer approved May 11, 2020
@balloob
Copy link
Member

balloob commented May 11, 2020

@Frederike create an errors dict and pass it to async_show_form. Use the field name to show the error near the field. Use the name "base" if you want to show the error above the form.

@fredrike
Copy link
Contributor Author

@Frederike create an errors dict and pass it to async_show_form. Use the field name to show the error near the field. Use the name "base" if you want to show the error above the form.

Great! I'm updating the code right now..

@fredrike fredrike requested a review from balloob May 11, 2020 09:36
@balloob balloob merged commit 93f8d21 into home-assistant:dev May 11, 2020
Dev automation moved this from Reviewer approved to Done May 11, 2020
@lock lock bot locked and limited conversation to collaborators May 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants