New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle StorageError in the Broadlink integration #35986
Conversation
Hey there @Danielhiversen, mind taking a look at this pull request as its been labeled with a integration ( |
Should we tag this for a patch release? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
@MartinHjelmare I think it's a good idea. |
I am able to replicate this on 0.111.4. I also had same issue on 0.110.2 and I just upgraded. |
I actually made it work after I put the "type" parameter in the remote and the switch. Not sure why is needed if optional. And the steps was to learn the commands and then add the switch. |
@ciumagcatalin The problem was with your config. It is necessary to inform the type for the latest Broadlink devices (see the troubleshooting section in the docs). Things will get simpler after this PR. |
Proposed change
In learning mode, devices of type 0x2737, 0x5f36 and RM4 series raise a StorageError when we try to read the code before it is stored in memory. It is simple to deal with this error, we just need to wait and retry.
Type of change
Example entry for
configuration.yaml
:Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale: