Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nanoleaf attribute when running an effect #36794

Merged
merged 1 commit into from Jun 15, 2020

Conversation

N1c093
Copy link
Contributor

@N1c093 N1c093 commented Jun 14, 2020

Proposed change

When you are running an effect on the nanoleaf the attributes "rgb_color", "xy_color", "hs_color" and "color_temp" return wrong values. Now we just return these attributes, when you are not running an effect.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml
light:
  - platform: nanoleaf
    host: 192.XXX.XXX.XX
    token: XXXXXXX

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

@homeassistant
Copy link
Contributor

Hi @N1c093,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@project-bot project-bot bot added this to Needs review in Dev Jun 14, 2020
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Dev automation moved this from Needs review to Reviewer approved Jun 15, 2020
@MartinHjelmare MartinHjelmare merged commit 717a21d into home-assistant:dev Jun 15, 2020
Dev automation moved this from Reviewer approved to Done Jun 15, 2020
@MartinHjelmare MartinHjelmare added this to the 0.111.3 milestone Jun 15, 2020
@balloob balloob mentioned this pull request Jun 15, 2020
@N1c093 N1c093 deleted the Fix-nanoleaf-attributes branch April 1, 2021 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

Nanoleaf return wrong attributes when running an effect
4 participants