Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove invalidation version from ZHA deprecated config options #37089

Merged
merged 1 commit into from Jun 25, 2020

Conversation

frenck
Copy link
Member

@frenck frenck commented Jun 25, 2020

Proposed change

Some YAML options of ZHA have been deprecated and marked as invalid as of Home Assistant Core 0.112.0.
However, they have not been removed, and while bumping the dev branch to 0.113.0dev0 (#37071), it broke the build.

As the beta has been cut already, I've removed the invalidation_version as a hotfix to pick for the 0.112.0 release (in the current state, the final stable release would fail building).

Nevertheless, this still needs clean up afterward.

=================================== FAILURES ===================================
_________________ test_migration_from_v1_with_baudrate[pyloop] _________________
[gw1] linux -- Python 3.7.0 /__w/1/s/venv/bin/python

hass = <homeassistant.core.HomeAssistant object at 0x7fa157655ef0>
config_entry_v1 = <tests.common.MockConfigEntry object at 0x7fa1576bd048>

    @patch("homeassistant.components.zha.async_setup_entry", AsyncMock(return_value=True))
    async def test_migration_from_v1_with_baudrate(hass, config_entry_v1):
        """Test migration of config entry from v1 with baudrate in config."""
        config_entry_v1.add_to_hass(hass)
>       assert await async_setup_component(hass, DOMAIN, {DOMAIN: {CONF_BAUDRATE: 115200}})
E       assert False

tests/components/zha/test_init.py:51: AssertionError
---------------------------- Captured stderr setup -----------------------------
DEBUG:asyncio:Using selector: EpollSelector
------------------------------ Captured log setup ------------------------------
DEBUG    asyncio:selector_events.py:64 Using selector: EpollSelector
----------------------------- Captured stderr call -----------------------------
INFO:homeassistant.loader:Loaded test from custom_components.test
INFO:homeassistant.loader:Loaded test_package from custom_components.test_package
INFO:homeassistant.loader:Loaded zha from homeassistant.components.zha
ERROR:homeassistant.config:Invalid config for [zha]: The 'baudrate' option is deprecated, please remove it from your configuration. This option became invalid in version 0.112 for dictionary value @ data['zha']. Got {'baudrate': 115200}. (See ?, line ?). Please check the docs at https://www.home-assistant.io/integrations/zha
ERROR:homeassistant.setup:Setup failed for zha: Invalid config.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

@project-bot project-bot bot added this to Needs review in Dev Jun 25, 2020
@probot-home-assistant probot-home-assistant bot added bugfix integration: zha small-pr PRs with less than 30 lines. labels Jun 25, 2020
@frenck frenck mentioned this pull request Jun 25, 2020
20 tasks
@frenck frenck added this to the 0.112.0 milestone Jun 25, 2020
Copy link
Contributor

@Adminiuga Adminiuga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Dev automation moved this from Needs review to Reviewer approved Jun 25, 2020
@Adminiuga Adminiuga merged commit 140fc48 into dev Jun 25, 2020
Dev automation moved this from Reviewer approved to Done Jun 25, 2020
@delete-merged-branch delete-merged-branch bot deleted the frenck-2020-0655 branch June 25, 2020 12:17
@Adminiuga
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants