Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mode info attributes to script and automation #37815

Merged
merged 5 commits into from Jul 14, 2020
Merged

Conversation

bramkragten
Copy link
Member

Proposed change

Adds attributes to scripts and automations about the current mode/max/number of running.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

@probot-home-assistant
Copy link

Hey there @home-assistant/core, mind taking a look at this pull request as its been labeled with an integration (script) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@balloob
Copy link
Member

balloob commented Jul 13, 2020

FYI @pnbruckner

if self._domain == "scene":
return True
if self._domain == "script" and not can_cancel:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to be a breaking change for Homekit I think? (breaking has already happened in the other PR)

I wonder if Homekit should just always make these "activate only"?

CC @bdraco

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It shouldn't be breaking I guess, can_cancel would always be true.

Dev automation moved this from Needs review to Reviewer approved Jul 13, 2020
@bdraco
Copy link
Member

bdraco commented Jul 13, 2020

In frontend we probably should adjust this?

src/panels/lovelace/entity-rows/hui-script-entity-row.ts:        ${stateObj.attributes.can_cancel
src/state-summary/state-card-script.js:        <template is="dom-if" if="[[stateObj.attributes.can_cancel]]">
src/state-summary/state-card-script.js:        <template is="dom-if" if="[[!stateObj.attributes.can_cancel]]">

EDIT: home-assistant/frontend#6371

@bramkragten
Copy link
Member Author

In frontend we probably should adjust this?

src/panels/lovelace/entity-rows/hui-script-entity-row.ts:        ${stateObj.attributes.can_cancel
src/state-summary/state-card-script.js:        <template is="dom-if" if="[[stateObj.attributes.can_cancel]]">
src/state-summary/state-card-script.js:        <template is="dom-if" if="[[!stateObj.attributes.can_cancel]]">

home-assistant/frontend#6371

@balloob balloob merged commit 7d77fa9 into dev Jul 14, 2020
Dev automation moved this from Reviewer approved to Done Jul 14, 2020
@balloob balloob deleted the mode-info-attributes branch July 14, 2020 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants