New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mode info attributes to script and automation #37815
Conversation
Hey there @home-assistant/core, mind taking a look at this pull request as its been labeled with an integration ( |
FYI @pnbruckner |
if self._domain == "scene": | ||
return True | ||
if self._domain == "script" and not can_cancel: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is going to be a breaking change for Homekit I think? (breaking has already happened in the other PR)
I wonder if Homekit should just always make these "activate only"?
CC @bdraco
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It shouldn't be breaking I guess, can_cancel
would always be true.
In frontend we probably should adjust this?
|
|
Proposed change
Adds attributes to scripts and automations about the current mode/max/number of running.
Type of change
Example entry for
configuration.yaml
:# Example configuration.yaml
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale: