Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch async_track_state_change to the faster async_track_state_change_event part 2 #37834

Merged

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Jul 14, 2020

I'm slowly switching these over so async_track_state_change_event gets used in new code instead of async_track_state_change when possible since code tends to get copied.

Proposed change

Calling async_track_state_change_event directly is faster than async_track_state_change (see #37251) since async_track_state_change is a wrapper around async_track_state_change_event now

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

…e_event

async_track_state_change_event is faster than async_track_state_change
@probot-home-assistant probot-home-assistant bot added core integration: group small-pr PRs with less than 30 lines. labels Jul 14, 2020
@project-bot project-bot bot added this to Needs review in Dev Jul 14, 2020
@bdraco bdraco changed the title Switch async_track_state_change to the faster async_track_state_change_event Switch async_track_state_change to the faster async_track_state_change_event part 2 Jul 14, 2020
@bdraco
Copy link
Member Author

bdraco commented Jul 14, 2020

Manual testing confirmed ok

Screen Shot 2020-07-14 at 7 31 04 AM

Dev automation moved this from Needs review to Reviewer approved Jul 15, 2020
@balloob balloob merged commit b12566e into home-assistant:dev Jul 15, 2020
Dev automation moved this from Reviewer approved to Done Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants