Use IP Address (host) provided by mDNS on Elgato Key Light

[pedrolamas]

Proposed change

On Elgato Key Light integration, take the IP reported by mDNS/Zeroconf, obtain the local domain name, and use that for the rest of the configuration flow (instead of the mDNS name)

Type of change

• Dependency upgrade

• Bugfix (non-breaking change which fixes an issue)

• New integration (thank you!)

• New feature (which adds functionality to an existing integration)

• Breaking change (fix/feature causing existing functionality to break)

• Code quality improvements to existing code or addition of tests

• This PR fixes or closes issue: fixes Use host for mDNS on Elgato Key Light discovery integration #38537

• This PR is related to issue:

• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• The code has been formatted using Black (black --fast homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

• No score or internal
• 🥈 Silver
• 🥇 Gold
• 🏆 Platinum

[probot-home-assistant]

Hey there @frenck, mind taking a look at this pull request as its been labeled with an integration (elgato) you are listed as a codeowner for? Thanks!
_{^{(message by CodeOwnersMention)}}

[frenck]

Please update the config entry instead.

Furthermore, some tests are failing that need to be adjusted.

[pedrolamas]

@frenck I made the changes and tests are now passing, but I was wondering if I should make the call to self.context.update() before the call to _abort_if_unique_id_configured() to make sure the host is updated?

[frenck]

Nope, the flow context is not related to the unique ID handling.

[pedrolamas]

Given that, and unless I'm missing something, I believe this is now complete!

[frenck]

self._abort_if_unique_id_configured()

Must now update the host in the existing config entry:

self._abort_if_unique_id_configured(updates={CONF_HOST: user_input[CONF_HOST]})

[pedrolamas]

Thanks for your patience, @frenck, I think I got it now (python is not my strong)

I also updated the test case to make sure that the host change is reflected in the config entry.

[frenck]

✅ Nice! One small issue with the formatting left (Black errored on the CI).

[pedrolamas]

@frenck that's now also fixed!

[frenck]

Thanks, @pedrolamas 👍