Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to use latest konnected py module #38803

Merged
merged 1 commit into from Aug 12, 2020

Conversation

kit-klein
Copy link
Contributor

@kit-klein kit-klein commented Aug 12, 2020

Proposed change

We noticed during load testing that the async konnected py module could overload the http stack inside konnected panels with too many simultaneous requests. When this happens CannotConnect exceptions are raised within the konnected component and the state change attempt will fail.

To mitigate this we updated the konnected py module to throttle state change attempts (max 3 at once) and retry upon failure. This completely resolves the issue.

This PR updates the konnected component to use this latest konnected py module (1.2.0).

konnected-io/konnected-py@7f611b2

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

@probot-home-assistant
Copy link

Hey there @heythisisnate, mind taking a look at this pull request as its been labeled with an integration (konnected) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@heythisisnate
Copy link
Contributor

LGTM 馃憤

@cgtobi
Copy link
Contributor

cgtobi commented Aug 12, 2020

Please add a link to the changlog of the konnected module.

@kit-klein
Copy link
Contributor Author

Please add a link to the changlog of the konnected module.

konnected-io/konnected-py@7f611b2

Copy link
Contributor

@cgtobi cgtobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cgtobi cgtobi merged commit 40f31fa into home-assistant:dev Aug 12, 2020
weissm pushed a commit to weissm/core that referenced this pull request Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants