Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump netdisco to 2.8.2 to accomodate new zeroconf exception #38949

Merged

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Aug 16, 2020

Needs home-assistant-libs/netdisco#254

Proposed change

Zeroconf now throws a BadTypeInNameException when it encounters
a bad name on the network. This causes a ServiceBrowser that
is calling ServiceInfo to collapse when trying to lookup
the service information.

zeroconf accommodated this in #38851
homekit_controller accommodated this in #38901

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@project-bot project-bot bot added this to Needs review in Dev Aug 16, 2020
@bdraco bdraco added the waiting-for-upstream We're waiting for a change upstream label Aug 16, 2020
@balloob balloob removed the waiting-for-upstream We're waiting for a change upstream label Aug 17, 2020
Dev automation moved this from Needs review to Reviewer approved Aug 17, 2020
@balloob balloob merged commit 49edd91 into home-assistant:dev Aug 17, 2020
Dev automation moved this from Reviewer approved to Done Aug 17, 2020
@bdraco bdraco added this to the 0.114.3 milestone Aug 17, 2020
@balloob balloob mentioned this pull request Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

Newer Yeelights throw zeroconf error in 0.114.1
3 participants