Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim CW from RGB when not supported in ozw #39191

Merged
merged 2 commits into from Aug 23, 2020
Merged

Trim CW from RGB when not supported in ozw #39191

merged 2 commits into from Aug 23, 2020

Conversation

firstof9
Copy link
Contributor

Proposed change

Trim the CW from RGB if CW isn't supported.
OZW will not accept 10 value HEX if only 8 values are supported.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #n/a
  • This PR is related to issue: n/a
  • Link to documentation pull request: n/a

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @cgarwood, @marcelveldt, @MartinHjelmare, mind taking a look at this pull request as its been labeled with an integration (ozw) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Dev automation moved this from Needs review to Reviewer approved Aug 23, 2020
@MartinHjelmare MartinHjelmare changed the title Trim CW from RGB when not supported Trim CW from RGB when not supported in ozw Aug 23, 2020
@cgarwood cgarwood merged commit 7462d14 into home-assistant:dev Aug 23, 2020
Dev automation moved this from Reviewer approved to Done Aug 23, 2020
weissm pushed a commit to weissm/core that referenced this pull request Aug 28, 2020
* Trim the CW value if CW isn't supported

* Trim CW from white level as well
leikoilja pushed a commit to leikoilja/core that referenced this pull request Sep 6, 2020
* Trim the CW value if CW isn't supported

* Trim CW from white level as well
@firstof9 firstof9 deleted the ozw-rgb-tweak branch November 17, 2020 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants