Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use boolean for mqtt fan state #39332

Merged
merged 1 commit into from Aug 27, 2020

Conversation

emontnemery
Copy link
Contributor

@emontnemery emontnemery commented Aug 27, 2020

Proposed change

Revert parts of #39096 as requested by @MartinHjelmare

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@project-bot project-bot bot added this to Needs review in Dev Aug 27, 2020
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Aug 27, 2020
@probot-home-assistant
Copy link

Hey there @home-assistant/core, mind taking a look at this pull request as its been labeled with an integration (mqtt) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Dev automation moved this from By Code Owner to Reviewer approved Aug 27, 2020
@MartinHjelmare MartinHjelmare changed the title Remove parts of #39096 Use boolean for mqtt fan state Aug 27, 2020
@MartinHjelmare MartinHjelmare merged commit 4e39a00 into home-assistant:dev Aug 27, 2020
Dev automation moved this from Reviewer approved to Done Aug 27, 2020
weissm pushed a commit to weissm/core that referenced this pull request Aug 28, 2020
leikoilja pushed a commit to leikoilja/core that referenced this pull request Sep 6, 2020
@emontnemery emontnemery deleted the revert_39096 branch October 14, 2020 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants