Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update meteo_france to use CoordinatorEntity #39432

Merged

Conversation

springstan
Copy link
Member

Breaking change

Proposed change

Update meteo_france to use CoordinatorEntity

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @hacf-fr, @oncleben31, @Quentame, mind taking a look at this pull request as its been labeled with an integration (meteo_france) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@bdraco
Copy link
Member

bdraco commented Aug 30, 2020

Test failure is unrelated. I documented it here since its not the first time its failed on me

#39443

@Quentame Quentame merged commit 953626b into home-assistant:dev Aug 30, 2020
@springstan springstan deleted the meteo_france_use_coordinator_entity branch August 30, 2020 18:05
leikoilja pushed a commit to leikoilja/core that referenced this pull request Sep 6, 2020
* Update meteo_france to use CoordinatorEntity

* Update homeassistant/components/meteo_france/sensor.py

* Update homeassistant/components/meteo_france/weather.py

Co-authored-by: J. Nick Koston <nick@koston.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants