New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update meteo_france to use CoordinatorEntity #39432
Merged
Quentame
merged 3 commits into
home-assistant:dev
from
springstan:meteo_france_use_coordinator_entity
Aug 30, 2020
Merged
Update meteo_france to use CoordinatorEntity #39432
Quentame
merged 3 commits into
home-assistant:dev
from
springstan:meteo_france_use_coordinator_entity
Aug 30, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-home-assistant
bot
added
code-quality
integration: meteo_france
small-pr
PRs with less than 30 lines.
labels
Aug 30, 2020
bdraco
approved these changes
Aug 30, 2020
Hey there @hacf-fr, @oncleben31, @Quentame, mind taking a look at this pull request as its been labeled with an integration ( |
Test failure is unrelated. I documented it here since its not the first time its failed on me |
oncleben31
reviewed
Aug 30, 2020
bdraco
reviewed
Aug 30, 2020
bdraco
reviewed
Aug 30, 2020
Quentame
approved these changes
Aug 30, 2020
leikoilja
pushed a commit
to leikoilja/core
that referenced
this pull request
Sep 6, 2020
* Update meteo_france to use CoordinatorEntity * Update homeassistant/components/meteo_france/sensor.py * Update homeassistant/components/meteo_france/weather.py Co-authored-by: J. Nick Koston <nick@koston.org>
This was referenced Sep 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Update meteo_france to use CoordinatorEntity
Type of change
Example entry for
configuration.yaml
:# Example configuration.yaml
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: