Update risco to use CoordinatorEntity #39456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-home-assistant
bot
added
code-quality
integration: risco
small-pr
OnFreund
reviewed
Aug 30, 2020
| @@ -29,17 +15,10 @@ def _refresh_from_coordinator(self): | |||
| async def async_added_to_hass(self): | |||
| """When entity is added to hass.""" | |||
| self.async_on_remove( | |||
| self._coordinator.async_add_listener(self._refresh_from_coordinator) | |||
| self.coordinator.async_add_listener(self._refresh_from_coordinator) | |||
There was a problem hiding this comment.
won't this result in two calls to async_write_ha_state() (one directly from CoordinatorEntity and the other from RiscoEntity._refresh_from_coordinator())?
There was a problem hiding this comment.
not if super isnt called in risco method
ctalkington
approved these changes
Aug 30, 2020
|
I tested this locally - it's working well. |
leikoilja
pushed a commit
to leikoilja/core
that referenced
this pull request
Sep 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Update risco to use CoordinatorEntity
Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: