Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code cleanups for async_track_template_result #40737

Merged
merged 1 commit into from Sep 30, 2020

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Sep 28, 2020

Proposed change

Code cleanups for async_track_template_result.

We no longer need to make a copy of info to last_info each execution.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant probot-home-assistant bot added core small-pr PRs with less than 30 lines. labels Sep 28, 2020
@project-bot project-bot bot added this to Needs review in Dev Sep 28, 2020
@bdraco
Copy link
Member Author

bdraco commented Sep 30, 2020

In order to reduce the complexity and keep the code maintainable, I'm going to see about breaking all the listener management into a separate class after the ratelimit code is finished up in another PR.

Dev automation moved this from Needs review to Reviewer approved Sep 30, 2020
@balloob balloob merged commit 205cf57 into home-assistant:dev Sep 30, 2020
Dev automation moved this from Reviewer approved to Done Sep 30, 2020
Bre77 pushed a commit to Bre77/core that referenced this pull request Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed core small-pr PRs with less than 30 lines.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants