Use skip_configuration flag to skip requests in ZHA #41554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The on_off attribute is on the REPORT_CONFIG, so super().async_initialize already requests it from the device. No need to request it twice.
probot-home-assistant
bot
added
Hacktoberfest
integration: zha
new-feature
small-pr
|
Still have to fix imports order. |
abmantis
force-pushed
the
zha_faster_init_skipconfig
branch
from
77f9e5e
to
3df604e
Compare
…into zha_faster_init_skipconfig
|
@Adminiuga @dmulcahey Can you take a look please? |
Adminiuga
reviewed
Oct 12, 2020
Comment on lines
203
to
206
| if self._ch_pool.skip_configuration: | ||
| self._status = ChannelStatus.INITIALIZED | ||
| return | ||
|
|
There was a problem hiding this comment.
I'm wondering if this is going to affect restoration of Xiaomi based sensors values after a restart???
There was a problem hiding this comment.
You are right. Maybe I should do
if not from_cache and self._ch_pool.skip_configuration:
What do you think?
Adminiuga
reviewed
Oct 12, 2020
| ) | ||
| if power_source is not None: | ||
| self._power_source = power_source | ||
| if not self._ch_pool.skip_configuration: |
…into zha_faster_init_skipconfig
Adminiuga
reviewed
Oct 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Some initialization requests were still being made, despite skip_configuration being set for the device. Since devices that have this set to True don't usually reply without being constantly waked up, we can skip some requests to make pairing quicker.
Note: we could add a skip_initialization flag, but I don't think that's really needed atm.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: