Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate ptvsd integration #42351

Merged
merged 2 commits into from Oct 26, 2020
Merged

Deprecate ptvsd integration #42351

merged 2 commits into from Oct 26, 2020

Conversation

frenck
Copy link
Member

@frenck frenck commented Oct 25, 2020

Breaking change

The ptvsd integration is been marked as deprecated and will be removed in Home Assistant Core 0.120.
A full-featured replacement is available with the debugpy integration, which is now considered stable.

Proposed change

With PR #40929, debugpy is now stable. Therefore a full (and superior) replacement for ptvsd.
This PR marks ptvsd as deprecated for 2 releases.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @Swamp-Ig, mind taking a look at this pull request as its been labeled with an integration (ptvsd) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

Dev automation moved this from Needs review to Reviewer approved Oct 25, 2020
Copy link
Member

@springstan springstan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃憤

@balloob balloob merged commit 55a4aba into dev Oct 26, 2020
Dev automation moved this from Reviewer approved to Done Oct 26, 2020
@balloob balloob deleted the frenck-2020-0899 branch October 26, 2020 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

6 participants