Bump dependency for HomematicIP Cloud #43018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-home-assistant
bot
added
breaking-change
dependency
has-tests
integration: homematicip_cloud
small-pr
|
Can we run a migration to clean up the entities that can be safely deleted? |
|
Hi @balloob , |
|
Ok. This means that we can remove the breaking change. |
balloob
reviewed
Nov 11, 2020
| for hapid in hap.home.accessPointUpdateStates.keys(): | ||
| if er_entry.unique_id == f"HomematicipBatterySensor_{hapid}": | ||
| entity_registry.async_remove(er_entry.entity_id) | ||
| except Exception as err: # pylint: disable=broad-except: |
There was a problem hiding this comment.
Do not catch Exception. What can raise here ? Wrap only the code that can raise and with the errors that you expect.
There was a problem hiding this comment.
I was overly careful here. The check for the minimum version should be OK, so i removed try/catch.
balloob
reviewed
Nov 12, 2020
|
Hi, please add the to current beta. |
Tagging this for 0.118 as requested. |
balloob
added a commit
that referenced
this pull request
Nov 13, 2020
Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: