Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide HomeKit devices from discovery that are known to be problematic #44014

Merged
merged 1 commit into from Dec 7, 2020

Conversation

Jc2k
Copy link
Member

@Jc2k Jc2k commented Dec 7, 2020

Proposed change

Some devices should not be detected as pairable by default. For example:

  • Some Anker camera systems don't have stable device id's until they are paired (this seems to be a spec violation) so we can't ignore them. See Eufy cameras got discovered multiple times via HomeKit #42307.
  • Some HK devices would work with HA if only the vendor would tell the customer the pairing code needed to use their own device. For example the Hive heating system and Flic Bridge both support HomeKit but do not give users the pairing code, so they can't work in HA.

Classing this as a bug fix because of #42307.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

N/A

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@project-bot project-bot bot added this to Needs review in Dev Dec 7, 2020
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Dec 7, 2020
Dev automation moved this from By Code Owner to Reviewer approved Dec 7, 2020
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM

Tagging this for 1.0.0 as it might help reducing issues people experience.

@frenck frenck added this to the 1.0.0 milestone Dec 7, 2020
@frenck frenck merged commit 6ce45e3 into home-assistant:dev Dec 7, 2020
Dev automation moved this from Reviewer approved to Done Dec 7, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Dec 8, 2020
@Jc2k Jc2k deleted the homekit_controller_hide branch August 5, 2021 21:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

Eufy cameras got discovered multiple times via HomeKit
3 participants