Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade mypy to 0.800 #45485

Merged
merged 4 commits into from Jan 30, 2021
Merged

Upgrade mypy to 0.800 #45485

merged 4 commits into from Jan 30, 2021

Conversation

scop
Copy link
Member

@scop scop commented Jan 24, 2021

Proposed change

https://mypy-lang.blogspot.com/2021/01/mypy-0800-released.html

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant probot-home-assistant bot added code-quality core small-pr PRs with less than 30 lines. labels Jan 24, 2021
@project-bot project-bot bot added this to Needs review in Dev Jan 24, 2021
@cdce8p cdce8p mentioned this pull request Jan 25, 2021
21 tasks
@cdce8p
Copy link
Member

cdce8p commented Jan 30, 2021

I've pushed my changes. Please let me know what you think.

homeassistant/util/logging.py Outdated Show resolved Hide resolved
homeassistant/util/logging.py Outdated Show resolved Hide resolved
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Dev automation moved this from Needs review to Reviewer approved Jan 30, 2021
@cdce8p cdce8p merged commit d13b58a into dev Jan 30, 2021
Dev automation moved this from Reviewer approved to Done Jan 30, 2021
@cdce8p cdce8p deleted the upgrade-mypy branch January 30, 2021 21:33
@github-actions github-actions bot locked and limited conversation to collaborators Jan 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants