Update insteon to use new fan entity model #45767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-home-assistant
bot
added
integration: insteon
small-pr
|
Hey there @teharris1, mind taking a look at this pull request as its been labeled with an integration ( |
frenck
approved these changes
Jan 31, 2021
| def speed_list(self) -> list: | ||
| """Get the list of available speeds.""" | ||
| return FAN_SPEEDS | ||
| def percentage(self) -> str: |
There was a problem hiding this comment.
The percentage should be an integer, right? And optional.
| SPEED_MEDIUM: FanSpeed.MEDIUM, | ||
| SPEED_HIGH: FanSpeed.HIGH, | ||
| } | ||
| SPEED_RANGE = (1, FanSpeed.HIGH) # off is not included |
There was a problem hiding this comment.
The constant is an IntEnum I assume?
c0fec0de
pushed a commit
to c0fec0de/home-assistant
that referenced
this pull request
Feb 1, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Update insteon to use new fan entity model
Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: