Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade numato-gpio to 0.10.0 #47539

Merged
merged 1 commit into from Mar 11, 2021
Merged

Conversation

clssn
Copy link
Contributor

@clssn clssn commented Mar 6, 2021

This adds support for devices sending '\n\r' end-of-line sequences.

Breaking change

none

Proposed change

I got aware of multiple users that they have Numato devices which respond with different end-of-line sequences ('\n\r') than those the numato-gpio module supported so far ('\r\n'), even devices with the same firmware version.

I upgraded the numato-gpio module to detect and support both '\r\n' and '\n\r' eol-sequences, having some affected users as well as new unit tests ensure this works. Resulting version is 0.10.0.

This is an upgrade of the HA Numato integration's numato-gpio dependency to 0.10.0 with no breaking change.

Changelog: https://github.com/clssn/numato-gpio/blob/v0.10.0/changelog.md

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml (you need a Numato device to actually test this)
numato:
  devices:
    - id: 0
      binary_sensors:
        ports:
          2: Window Livingroom Open
          3: Window Livingroom Glassbreak
          4: Doorbell
      sensors:
        ports:
          1:
            name: Soil Moisture Ficus
      switches:
        ports:
          5: Relay Light Outdoor
          6: Relay Circulation Pump
          7: Door Opener

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

This adds support for devices sending '\n\r' end-of-line sequences.
@project-bot project-bot bot added this to Needs review in Dev Mar 6, 2021
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Mar 6, 2021
@cgtobi
Copy link
Contributor

cgtobi commented Mar 6, 2021

Please add a link to a changelog or GitHub commit compare view for the version bump in the PR description. Thanks!

@clssn
Copy link
Contributor Author

clssn commented Mar 11, 2021

@cgtobi I Added the requested link under Additional Information.

@clssn clssn closed this Mar 11, 2021
Dev automation moved this from By Code Owner to Cancelled Mar 11, 2021
@clssn clssn reopened this Mar 11, 2021
Dev automation moved this from Cancelled to Incoming Mar 11, 2021
@cgtobi cgtobi merged commit 3ebc262 into home-assistant:dev Mar 11, 2021
Dev automation moved this from Incoming to Done Mar 11, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Mar 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants