Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ScreenLogic cleanups #48136

Merged
merged 6 commits into from Mar 21, 2021
Merged

ScreenLogic cleanups #48136

merged 6 commits into from Mar 21, 2021

Conversation

dieselrabbit
Copy link
Contributor

@dieselrabbit dieselrabbit commented Mar 20, 2021 •
edited by bdraco

Proposed change

Bump screenlogicpy to 0.2.0.
Move heating functions from water_heater to climate platform.
Address notes from original PR.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

N/A

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@project-bot project-bot bot added this to Needs review in Dev Mar 20, 2021
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Mar 20, 2021
@dieselrabbit dieselrabbit mentioned this pull request Mar 20, 2021
Merged
8 tasks
@bdraco bdraco changed the title ScreenLogic cleanup. ScreenLogic cleanups Mar 20, 2021
@bdraco
Copy link
Member

bdraco commented Mar 20, 2021

Its not considered a breaking change since its unreleased

@dieselrabbit
ScreenLogic cleanup.
680cab9 
Bump screenlogicpy to 0.2.0.
Move heating functions from water_heater to climate platform.
Address notes from original PR.
@dieselrabbit
Fix temperature attribute
da84d69
@dieselrabbit
Addressing notes.
2d488e2 
Bump screenlogicpy to 0.2.1.
Made device_types constants.
Made (known) equipment flags constants.
Used dict.get() in places where None is the default.
Return fast with good _last_preset.
MartinHjelmare
MartinHjelmare requested changes Mar 20, 2021
View reviewed changes
homeassistant/components/screenlogic/climate.py Outdated Show resolved Hide resolved
homeassistant/components/screenlogic/climate.py Outdated Show resolved Hide resolved
homeassistant/components/screenlogic/climate.py Outdated Show resolved Hide resolved
tests/components/screenlogic/test_config_flow.py Show resolved Hide resolved
tests/components/screenlogic/test_config_flow.py Outdated Show resolved Hide resolved
Dev automation moved this from By Code Owner to Review in progress Mar 20, 2021
@dieselrabbit @bdraco
Update homeassistant/components/screenlogic/climate.py
4bfc132 
Let base entity handle state property.

Co-authored-by: J. Nick Koston <nick@koston.org>
@bdraco
Copy link
Member

bdraco commented Mar 20, 2021

Looks good! Martin has a better eye for detail though so I'll wait for him to weigh in.

@dieselrabbit
Copy link
Contributor Author

Sounds good. I greatly appreciate everyone's patience with me.

MartinHjelmare
MartinHjelmare approved these changes Mar 21, 2021
View reviewed changes
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Dev automation moved this from Review in progress to Reviewer approved Mar 21, 2021
@MartinHjelmare MartinHjelmare merged commit fb48fd7 into home-assistant:dev Mar 21, 2021
Dev automation moved this from Reviewer approved to Done Mar 21, 2021
@dieselrabbit dieselrabbit deleted the screenlogic-cleanup branch March 21, 2021 19:49
@github-actions github-actions bot locked and limited conversation to collaborators Mar 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bdraco bdraco bdraco left review comments

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees
No one assigned
Labels
by-code-owner cla-signed code-quality dependency has-tests integration: screenlogic new-platform remove-platform
Projects
Dev
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dieselrabbit @bdraco @MartinHjelmare @homeassistant