Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Waze Travel Time tests #52663

Merged
merged 1 commit into from Jul 7, 2021

Conversation

thecode
Copy link
Member

@thecode thecode commented Jul 7, 2021

Proposed change

Waze Travel Time tests actually fetch data from Waze servers during tests, this makes the test slow (about 9-10 seconds) and they fail sometime.

Running the tests prior to this change without internet connection resulted in the tests taking 127 seconds!.
waze
After the change the tests take about 0.5 second.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@project-bot project-bot bot added this to Needs review in Dev Jul 7, 2021
Dev automation moved this from Needs review to Reviewer approved Jul 7, 2021
Copy link
Contributor

@raman325 raman325 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for fixing this!

@thecode thecode merged commit 02d8d25 into home-assistant:dev Jul 7, 2021
Dev automation moved this from Reviewer approved to Done Jul 7, 2021
@thecode thecode deleted the fix-waze-travel-time-tests branch July 7, 2021 20:56
tkdrob pushed a commit to tkdrob/core that referenced this pull request Jul 8, 2021
sjiampojamarn pushed a commit to sjiampojamarn/core that referenced this pull request Jul 8, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jul 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants