Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for fan speeds and support reverse #53105

Merged
merged 1 commit into from Jul 21, 2021

Conversation

elupus
Copy link
Contributor

@elupus elupus commented Jul 16, 2021

Breaking change

  • Requires resync of google assysten devices since we no longer expose fan speeds. Ask your google device to "Sync my devices" or trigger update via google_assistant.request_sync service.

Proposed change

This change will drop support for the legacy fan speeds. The google docs is a bit unclear as to if it is a supported state to have both fanspeeds and percentages. So let's only support percentages since we have issue's where google still call the legacy services.

Also add support for fan reversion service that we claimed to support, but really didn't.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@project-bot project-bot bot added this to Needs review in Dev Jul 16, 2021
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Jul 20, 2021
Dev automation moved this from Needs review to Reviewer approved Jul 21, 2021
@balloob balloob merged commit 8a7cb38 into home-assistant:dev Jul 21, 2021
Dev automation moved this from Reviewer approved to Done Jul 21, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jul 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants