Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use NamedTuple - nws #53293

Merged
merged 1 commit into from Jul 22, 2021
Merged

Use NamedTuple - nws #53293

merged 1 commit into from Jul 22, 2021

Conversation

cdce8p
Copy link
Member

@cdce8p cdce8p commented Jul 21, 2021

Proposed change

Update nws to use NamedTuple for sensor metadata.
-> #53201

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@project-bot project-bot bot added this to Needs review in Dev Jul 21, 2021
@cdce8p cdce8p added the project-code_style PRs related to #53201 - pylint CodeStyle update label Jul 21, 2021
@probot-home-assistant
Copy link

Hey there @MatthewFlamm, mind taking a look at this pull request as its been labeled with an integration (nws) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Jul 21, 2021
Copy link
Contributor

@MatthewFlamm MatthewFlamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Dev automation moved this from Needs review to Reviewer approved Jul 22, 2021
@balloob balloob merged commit d98e580 into home-assistant:dev Jul 22, 2021
Dev automation moved this from Reviewer approved to Done Jul 22, 2021
@cdce8p cdce8p deleted the cs-nws branch July 22, 2021 07:53
@github-actions github-actions bot locked and limited conversation to collaborators Jul 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed code-quality has-tests integration: nws project-code_style PRs related to #53201 - pylint CodeStyle update smash Indicator this PR is close to finish for merging or closing
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants