Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add date device class #55887

Merged
merged 2 commits into from Sep 7, 2021
Merged

Conversation

scop
Copy link
Member

@scop scop commented Sep 7, 2021

Proposed change

Per home-assistant/architecture#610

No usages yet, but I'm planning to add one soonish. The reason I'm not bundling this with that mentioned change is that I'd rather not delay its inclusion in case e.g. implementing support for this device class in the frontend starts to take some time -- in the meanwhile I can use DEVICE_CLASS_TIMESTAMP sufficiently.

Child PR's:

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@scop scop requested a review from a team as a code owner September 7, 2021 05:05
@probot-home-assistant probot-home-assistant bot added core new-feature small-pr PRs with less than 30 lines. labels Sep 7, 2021
@project-bot project-bot bot added this to Needs review in Dev Sep 7, 2021
@MartinHjelmare
Copy link
Member

Please see this PR and all its linked PRs for a template of what needs to be included when adding a sensor device class:

#55050

@scop
Copy link
Member Author

scop commented Sep 7, 2021

Thanks. Expanded this one some, and added child PR's, links in OP. Looking at how timestamp is implemented, I suppose like it, this'll need fewer modifications than the voc adddition.

@MartinHjelmare
Copy link
Member

Yeah, the lack of a unit of measurement for the device class will decrease the needed changes.

Dev automation moved this from Needs review to Reviewer approved Sep 7, 2021
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare merged commit 0684f8b into home-assistant:dev Sep 7, 2021
Dev automation moved this from Reviewer approved to Done Sep 7, 2021
@scop scop deleted the scop-device-class-date branch September 7, 2021 14:51
@github-actions github-actions bot locked and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants