Prevent 3rd party lib from opening sockets in glances tests #56345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-home-assistant
bot
added
code-quality
has-tests
integration: glances
small-pr
|
Hey there @fabaff, @engrbm87, mind taking a look at this pull request as it has been labeled with an integration ( |
emontnemery
commented
Sep 17, 2021
| @@ -54,7 +52,10 @@ async def test_form(hass): | |||
| async def test_form_cannot_connect(hass): | |||
| """Test to return error if we cannot connect.""" | |||
|
|
|||
| with patch("glances_api.Glances"): | |||
There was a problem hiding this comment.
This was not correctly mocked out, we were actually trying to connect to the API, which failed.
| with patch("glances_api.Glances"), patch.object( | ||
| Glances, "get_data", return_value=mock_coro() | ||
| ): | ||
| with patch("homeassistant.components.glances.Glances.get_data", autospec=True): |
There was a problem hiding this comment.
It's enough to just mock out the function with autospec enabled.
22 tasks
bdraco
approved these changes
Sep 18, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Prevent 3rd party lib from opening sockets in glances tests
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: