New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure sonos always gets ssdp callbacks from searches #56591
Ensure sonos always gets ssdp callbacks from searches #56591
Conversation
@StevenLooman I bumped to 0.22.0 here. Unfortunately it looks like there is a regression as the UPNP entry for my UDM pro no longer has any entities. |
UDM pro is your router, I think? Can you check if the IGDv1 (or v2) device is an embedded device? Or better yet, can you send the device description (xml) file? |
StevenLooman/async_upnp_client#88 is on its way. |
Also I think we can remove |
|
Published |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No doubt you'll upgrade the PR to async-upnp-client==0.22.1
.
Proposed change
#55540 limited callbacks to only happen when something had changed in the search. This is great for performance, but unfortunately, Sonos needs the callback regardless to tell it the device is still alive.
SEARCH_ALIVE
- Search response, device is aliveSEARCH_CHANGED
- Search response, device is new or an attribute changed (implies the device is alive since it responded)Requires StevenLooman/async_upnp_client#87
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: