Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure sonos always gets ssdp callbacks from searches #56591

Merged
merged 8 commits into from Sep 26, 2021

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Sep 23, 2021

Proposed change

#55540 limited callbacks to only happen when something had changed in the search. This is great for performance, but unfortunately, Sonos needs the callback regardless to tell it the device is still alive.

  • Add more detail to the change type

SEARCH_ALIVE - Search response, device is alive
SEARCH_CHANGED - Search response, device is new or an attribute changed (implies the device is alive since it responded)

Requires StevenLooman/async_upnp_client#87

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@project-bot project-bot bot added this to Needs review in Dev Sep 23, 2021
@probot-home-assistant probot-home-assistant bot added integration: ssdp small-pr PRs with less than 30 lines. labels Sep 23, 2021
@bdraco bdraco added the waiting-for-upstream We're waiting for a change upstream label Sep 23, 2021
Dev automation moved this from Needs review to Reviewer approved Sep 24, 2021
@bdraco bdraco removed the waiting-for-upstream We're waiting for a change upstream label Sep 25, 2021
@bdraco bdraco marked this pull request as ready for review September 25, 2021 22:11
@bdraco bdraco marked this pull request as draft September 25, 2021 23:25
@bdraco
Copy link
Member Author

bdraco commented Sep 25, 2021

@StevenLooman I bumped to 0.22.0 here. Unfortunately it looks like there is a regression as the UPNP entry for my UDM pro no longer has any entities.

@StevenLooman
Copy link
Contributor

@StevenLooman I bumped to 0.22.0 here. Unfortunately it looks like there is a regression as the UPNP entry for my UDM pro no longer has any entities.

UDM pro is your router, I think? Can you check if the IGDv1 (or v2) device is an embedded device? Or better yet, can you send the device description (xml) file?

@StevenLooman
Copy link
Contributor

StevenLooman/async_upnp_client#88 is on its way.

@bdraco
Copy link
Member Author

bdraco commented Sep 26, 2021

Also I think we can remove defusedxml from the requirements of ssdp in a future PR since its no longer used directly.

@bdraco
Copy link
Member Author

bdraco commented Sep 26, 2021

StevenLooman/async_upnp_client#88 is on its way.

Pulled your branch. Tested and working 馃憤
Screen_Shot_2021-09-26_at_3_31_37_PM

@StevenLooman
Copy link
Contributor

Published async-upnp-client==0.22.1

Copy link
Contributor

@StevenLooman StevenLooman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No doubt you'll upgrade the PR to async-upnp-client==0.22.1.

homeassistant/components/ssdp/__init__.py Show resolved Hide resolved
@bdraco bdraco marked this pull request as ready for review September 26, 2021 20:56
@bdraco bdraco merged commit 26e0319 into home-assistant:dev Sep 26, 2021
Dev automation moved this from Reviewer approved to Done Sep 26, 2021
@bdraco bdraco deleted the ssdp_always_callback_search branch September 26, 2021 22:16
@github-actions github-actions bot locked and limited conversation to collaborators Sep 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants