Use value_fn for bmw_connected_drive binary_sensor

[cdce8p]

Proposed change

Refactor bmw_connected_drive binary_sensor to use value_fn as attribute on the EntityDescription. By doing so we can remove almost all logic from the update method itself.

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• The code has been formatted using Black (black --fast homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
• Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

• No score or internal
• 🥈 Silver
• 🥇 Gold
• 🏆 Platinum

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[probot-home-assistant]

Hey there @gerard33, @rikroe, mind taking a look at this pull request as it has been labeled with an integration (bmw_connected_drive) you are listed as a code owner for? Thanks!
_{^{(message by CodeOwnersMention)}}

[rikroe]

While the diff looks very confusing I like the end result.

Unfortunately, cannot test this on my car, but at least no errors/warning are raised (i.e. it still ignores sensors your car doesn't have).

Thanks!

[cdce8p]

@gerard33 Would you be able to test this change, too?

[gerard33]

Sure will also test this change.

[gerard33]

All binary sensors work fine for my car with combustion engine (so can't test the EV binary sensors 😉).

[rytilahti]

Please rebase on top of the current dev branch.

[cdce8p]

Please rebase on top of the current dev branch.

👍🏻 Did the rebase. As it has been tested already, I would argue this PR is almost done and could be merged as is.

[frenck]

LGTM, Thanks @cdce8p 👍