Skip to content

Add state_class support to Rest - #58026

Merged
allenporter merged 1 commit into
home-assistant:devfrom
koying:addstateclasstorest
Oct 22, 2021
Merged

Add state_class support to Rest#58026
allenporter merged 1 commit into
home-assistant:devfrom
koying:addstateclasstorest

Conversation

@koying

@koying koying commented Oct 19, 2021

Copy link
Copy Markdown
Contributor

Proposed change

Add state_class support to Rest sensors.

Use case: Retrieve energy consumption from provider by REST.
User expectation is to be able to use that sensor in the Energy panel without going through a customize.yaml step.

While I was at it:

  • Use _attr_* when possible
  • Add device_class support to REST switch for consistency

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@allenporter
allenporter merged commit 1867d24 into home-assistant:dev Oct 22, 2021
Chen-IL pushed a commit to Chen-IL/homeassistant-core that referenced this pull request Oct 23, 2021
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed Hacktoberfest has-tests integration: rest new-feature small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants