Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update surepetcare services.yaml #58892

Merged
merged 1 commit into from Nov 14, 2021
Merged

Update surepetcare services.yaml #58892

merged 1 commit into from Nov 14, 2021

Conversation

flyize
Copy link
Contributor

@flyize flyize commented Nov 1, 2021

Incorrect capitalization in example data fails.

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

Incorrect capitalization in example data fails.
@homeassistant
Copy link
Contributor

Hi @flyize,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@probot-home-assistant
Copy link

Hey there @benleb, @Danielhiversen, mind taking a look at this pull request as it has been labeled with an integration (surepetcare) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@MartinHjelmare MartinHjelmare changed the title Update services.yaml Update surepetcare services.yaml Nov 1, 2021
@frenck
Copy link
Member

frenck commented Nov 1, 2021

@flyize Thanks for the PR, could you please sign the CLA as linked above?

Dev automation moved this from Needs review to Reviewer approved Nov 1, 2021
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@project-bot project-bot bot moved this from Reviewer approved to Needs review in Dev Nov 2, 2021
@frenck frenck merged commit 70de7db into home-assistant:dev Nov 14, 2021
Dev automation moved this from Needs review to Done Nov 14, 2021
@flyize flyize deleted the patch-1 branch November 14, 2021 17:36
bachya pushed a commit to bachya/home-assistant that referenced this pull request Nov 14, 2021
bachya pushed a commit to bachya/home-assistant that referenced this pull request Nov 14, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Nov 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants