Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Yamaha MusicCast Select Entities #60645

Merged
merged 5 commits into from Dec 6, 2021
Merged

Add Yamaha MusicCast Select Entities #60645

merged 5 commits into from Dec 6, 2021

Conversation

micha91
Copy link
Contributor

@micha91 micha91 commented Nov 30, 2021

Proposed change

After we already added number entities for configuration purposes the following select entities will be made available for MusicCast devices supporting them.

Device specific entities:

  • Dimmer
    • Set the display brightness

Zone specific entities:

  • Surround Decoder Type
    • If sound program is set to surround decoder, the decoder type can be selected here
  • Sleep
    • Set a sleep timer for the device
  • Equalizer Mode
    • Some devices support multiple different equalizer modes
  • Tone Control Mode
    • Some devices support multiple different tone control modes
  • Link Audio Delay
    • Some devices let the user select, whether he wants to have audio and video in sync or the linked speakers of a group
  • Link Control
    • Some devices support compressed audio for groups
  • Link Audio Quality
    • Set the audio quality for grouped speakers

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @vigonotion, mind taking a look at this pull request as it has been labeled with an integration (yamaha_musiccast) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Nov 30, 2021
Copy link
Contributor

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but please fix the translations

@micha91
Copy link
Contributor Author

micha91 commented Dec 2, 2021

Looks good, but please fix the translations

Thanks for the hint. I did not realize that we also work this way for status values, but I like that 👍

Dev automation moved this from By Code Owner to Reviewer approved Dec 6, 2021
Copy link
Contributor

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @micha91 👍

@emontnemery emontnemery merged commit f94085c into home-assistant:dev Dec 6, 2021
Dev automation moved this from Reviewer approved to Done Dec 6, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Dec 7, 2021
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the comment in a new PR. Thanks!

@property
def device_class(self) -> str:
"""Return the ID of the capability, to identify the entity for translations."""
return f"{DOMAIN}__{self.capability.id.lower()}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please define the valid device classes in a container here in the platform and validate the device class before returning it. The device class is a Home Assistant API so we need to be in control and make sure it is correct before returning it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants