Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BMW Connected Drive #60938

Merged
merged 9 commits into from Dec 5, 2021
Merged

Conversation

rikroe
Copy link
Contributor

@rikroe rikroe commented Dec 3, 2021

Breaking change

The find_vehicle service will always send the location of your HA instance to BMW. See the docs for details.

Proposed change

This PR contains a bugfixes to #59881.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @gerard33, mind taking a look at this pull request as it has been labeled with an integration (bmw_connected_drive) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@project-bot project-bot bot added this to Needs review in Dev Dec 3, 2021
Dev automation moved this from Needs review to Review in progress Dec 3, 2021
@rikroe rikroe changed the title Bugfixes to BMW Connected Drive, add charging_end_time sensor Bugfixes to BMW Connected Drive Dec 3, 2021
@rikroe
Copy link
Contributor Author

rikroe commented Dec 4, 2021

Removed the deletion of CONF_USE_LOCATION from options and added a breaking change description that will link to the documentation (of course requiring the docs PR that I just created to be merged as well :) ).

@MartinHjelmare
Copy link
Member

Has the BMW api already changed to require a location? Ie, there's no reason to wait with releasing this breaking change?

@rikroe
Copy link
Contributor Author

rikroe commented Dec 4, 2021

Just removed the stale string.

And yes, the BMW API has already changed. I just didn't catch everything at once with #59881.

@MartinHjelmare MartinHjelmare changed the title Bugfixes to BMW Connected Drive Fix BMW Connected Drive Dec 5, 2021
@MartinHjelmare MartinHjelmare added this to the 2021.12.0 milestone Dec 5, 2021
Dev automation moved this from Review in progress to Reviewer approved Dec 5, 2021
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare merged commit 380c1a4 into home-assistant:dev Dec 5, 2021
Dev automation moved this from Reviewer approved to Done Dec 5, 2021
@rikroe
Copy link
Contributor Author

rikroe commented Dec 5, 2021

Thanks for your support as well!

balloob pushed a commit that referenced this pull request Dec 5, 2021
* Bump bimmer_connected to 0.8.5

* Always update HA states after service execution

* Fix BMW device tracker & vehicle_finder service

* Add charging_end_time sensor

* Fix pylint & pytest

* Remove unneeded DEFAULT_OPTION

* Revert adding charging_end_time & state_attributes

* Don't delete option data for CONF_USE_LOCATION

* Remove stale string

Co-authored-by: rikroe <rikroe@users.noreply.github.com>
@github-actions github-actions bot locked and limited conversation to collaborators Dec 6, 2021
@rikroe rikroe deleted the mybmw-bugfix branch June 3, 2022 10:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants