New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix BMW Connected Drive #60938
Fix BMW Connected Drive #60938
Conversation
Hey there @gerard33, mind taking a look at this pull request as it has been labeled with an integration ( |
Removed the deletion of |
Has the BMW api already changed to require a location? Ie, there's no reason to wait with releasing this breaking change? |
Just removed the stale string. And yes, the BMW API has already changed. I just didn't catch everything at once with #59881. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Thanks for your support as well! |
* Bump bimmer_connected to 0.8.5 * Always update HA states after service execution * Fix BMW device tracker & vehicle_finder service * Add charging_end_time sensor * Fix pylint & pytest * Remove unneeded DEFAULT_OPTION * Revert adding charging_end_time & state_attributes * Don't delete option data for CONF_USE_LOCATION * Remove stale string Co-authored-by: rikroe <rikroe@users.noreply.github.com>
Breaking change
The
find_vehicle
service will always send the location of your HA instance to BMW. See the docs for details.Proposed change
This PR contains a bugfixes to #59881.
bimmer_connected==0.8.5
find_vehicle
now returns & stores the position of the vehicle, however needs to send a location (using HA location)Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: