Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove loopenergy integration #61175

Merged
merged 3 commits into from Dec 7, 2021
Merged

Remove loopenergy integration #61175

merged 3 commits into from Dec 7, 2021

Conversation

cgarwood
Copy link
Member

@cgarwood cgarwood commented Dec 7, 2021 •
edited

Breaking change

Remove the loopenergy integration. Loop Energy shut down their API in November 2020.

Proposed change

Remove the loopenergy integration. Loop Energy shut down their API in November 2020.
Docs PR: home-assistant/home-assistant.io#20607

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

@cgarwood cgarwood requested a review from pavoni as a code owner December 7, 2021 16:26
@project-bot project-bot bot added this to Needs review in Dev Dec 7, 2021
@probot-home-assistant
Copy link

Hey there @pavoni, mind taking a look at this pull request as it has been labeled with an integration (loopenergy) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@cgarwood
Copy link
Member Author

cgarwood commented Dec 7, 2021

I'm not sure why script.gen_requirements_all modified colorlog and pyotp as it was from a fresh dev branch...

@cgarwood cgarwood mentioned this pull request Dec 7, 2021
Merged
8 tasks
@cgarwood
Copy link
Member Author

cgarwood commented Dec 7, 2021

Fixed requirements files.

This was referenced Dec 7, 2021
Merged
Merged
@pavoni
Copy link
Contributor

pavoni commented Dec 7, 2021

Just to say as code owner I agree this should be removed!

Dev automation moved this from Needs review to Reviewer approved Dec 7, 2021
@MartinHjelmare MartinHjelmare merged commit 00a82bf into home-assistant:dev Dec 7, 2021
Dev automation moved this from Reviewer approved to Done Dec 7, 2021
@balloob balloob added this to the 2021.12.0 milestone Dec 7, 2021
balloob pushed a commit that referenced this pull request Dec 7, 2021
@cgarwood @balloob
Remove loopenergy integration (#61175)
61545ed 
* Remove loopenergy integration

* Fix requirements_all.txt

* Fix requirements_test_all.txt
@cgarwood cgarwood deleted the remove_loopenergy branch December 7, 2021 21:12
@github-actions github-actions bot locked and limited conversation to collaborators Dec 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

@pavoni pavoni Awaiting requested review from pavoni

Assignees

@pavoni pavoni

Labels
breaking-change cherry-picked cla-signed integration: loopenergy remove-platform small-pr PRs with less than 30 lines.
Projects
Dev
  
Done
Milestone
2021.12.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@cgarwood @pavoni @MartinHjelmare @balloob @homeassistant