New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow name-only location updates for mobile_app device_tracker #62243
Allow name-only location updates for mobile_app device_tracker #62243
Conversation
Hey there @robbiet480, mind taking a look at this pull request as it has been labeled with an integration ( |
We have also had this request in the android app where people dont want to report precise location but only zone names as well. One other thing we can do too with this change is to link wifi SSIDs to zones for users who do not have google services. CC: @JBassett |
I think it best to just start with zone only before worrying about SSID -> location mapping. |
Requires home-assistant/core#62243. ## Summary Allows sending exact locations (current behavior, gps coordinates), no locations (sets the device tracker to 'unknown' effectively), and zone-only locations (we send `home`, `other_zone_name` or `not_home` only). ## Link to pull request in Documentation repository Documentation: home-assistant/companion.home-assistant#639
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @zacwest 馃憤
Proposed change
Allows sending name-only updates to the device_trackers, for example to do
home
vs.not_home
without exposing accurate location values.Motivation here originates in multi-server support in the iOS app. We want to limit location exposure to some not-their-primary-server instances like a parent's or friend's instance.
I'm somewhat intentionally (rather than requiring one of the
location_name
/gps
keys) including the ability to redact the device_tracker (no gps/location name) and get it into the 'unknown' state.Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: