Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lock setup type hints #63296

Merged
merged 1 commit into from Jan 3, 2022
Merged

Add lock setup type hints #63296

merged 1 commit into from Jan 3, 2022

Conversation

epenet
Copy link
Contributor

@epenet epenet commented Jan 3, 2022

Proposed change

As follow-up to #63098, add type hint to lock.py for:

  • setup_platform
  • async_setup_platform
  • async_setup_entry

This PR is 100% type hint - zero code change. The components with code changes will be treated separately.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@project-bot project-bot bot added this to Needs review in Dev Jan 3, 2022
Dev automation moved this from Needs review to Reviewer approved Jan 3, 2022
@frenck frenck merged commit eed7ce5 into home-assistant:dev Jan 3, 2022
Dev automation moved this from Reviewer approved to Done Jan 3, 2022
@epenet epenet deleted the mypy-lock branch January 3, 2022 14:45
jeeftor pushed a commit to jeeftor/core that referenced this pull request Jan 4, 2022
Co-authored-by: epenet <epenet@users.noreply.github.com>
@github-actions github-actions bot locked and limited conversation to collaborators Jan 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants