Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better manage of nested lists in UniFi diagnostics #65176

Merged

Conversation

Kane610
Copy link
Member

@Kane610 Kane610 commented Jan 29, 2022

Breaking change

Proposed change

Depends on #65170 being resolved because that will currently also break on nested lists
Unfortunately I haven't received any real world data to use in tests here.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@Kane610 Kane610 added this to the 2022.2.0 milestone Jan 29, 2022
@project-bot project-bot bot added this to Needs review in Dev Jan 29, 2022
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Jan 29, 2022
Dev automation moved this from By Code Owner to Reviewer approved Jan 30, 2022
@balloob balloob merged commit ac1b30a into home-assistant:dev Jan 30, 2022
Dev automation moved this from Reviewer approved to Done Jan 30, 2022
@Kane610 Kane610 deleted the unifi-fix_replace_data_with_nested_lists branch January 30, 2022 22:02
@Kane610
Copy link
Member Author

Kane610 commented Jan 30, 2022

Thanks @balloob 馃帀

balloob pushed a commit that referenced this pull request Jan 31, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Feb 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants