New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create unique_id for sleepiq sensors #65227
Conversation
Hi @jarodwilson, It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
28c30e6
to
789be65
Compare
I find myself unable to run self-tests, due to inability to install required dependencies. It looks like there are plugins requiring both older and newer versions of async-timeout. From the error messages when trying to run tox:
Can't satisfy the dependencies of plugwise and everything that wants > 4.0. |
This is caused by using an incompatible pip version. Please make sure you are using the older (and pinned) |
Whoops, I managed to skip over all the dev environment setup bits and use of virtualenv. Makes sense, thank you for the cluebat. Self-tests now attempting to run... |
After struggling to get things entirely behaving on a native Linux install, I just did the docker container with vscode route, and:
[edit: post the testing from the modified branch, not the original, whoops] |
0a610cc
to
445b182
Compare
This way, they can be moved to areas (like a bedroom) and have their names customized. The basis is a bed ID returned by the sleepiq API, with sensors for both the left and right sides of the bed, followed by a sensor type of either 'is_in_bed' or 'sleep_number', which also map directly from the sleepiq API. Signed-off-by: Jarod Wilson <jarodwilson@gmail.com>
445b182
to
f21035c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @jarodwilson 馃憤
This way, they can be moved to areas (like a bedroom) and have their names
customized. The basis is a bed ID returned by the sleepiq API, with sensors
for both the left and right sides of the bed, followed by a sensor type of
either 'is_in_bed' or 'sleep_number', which also map directly from the
sleepiq API.
Signed-off-by: Jarod Wilson jarod@redhat.com
Breaking change
Proposed change
Simply add a unique_id property to the sleepiq sensor init, so that the sensors can be moved to other areas and have their names customized.
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: