Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SmartHab integration #67874

Merged
merged 1 commit into from Mar 20, 2022
Merged

Conversation

outadoc
Copy link
Contributor

@outadoc outadoc commented Mar 8, 2022

Breaking change

The SmartHab integration has been removed. It had not been working for months because the APIs would timeout. Turns out the company behind it has been shut down.

Proposed change

This PR removes the SmartHab integration. It had not been working for months because the APIs would timeout. They wouldn't reply to my support emails -- turns out the company behind it has been shut down. How surprising 馃檭

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@outadoc outadoc marked this pull request as ready for review March 8, 2022 19:40
@bdraco bdraco added the smash Indicator this PR is close to finish for merging or closing label Mar 8, 2022
@jeeftor
Copy link
Contributor

jeeftor commented Mar 9, 2022

Adios Amigo!!!!

@tkdrob
Copy link
Contributor

tkdrob commented Mar 14, 2022

Please resolve merge conflicts. Thanks

Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare merged commit a136cf7 into home-assistant:dev Mar 20, 2022
@outadoc outadoc deleted the remove-smarthab branch March 20, 2022 18:32
@github-actions github-actions bot locked and limited conversation to collaborators Mar 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking-change by-code-owner cla-signed integration: smarthab remove-platform small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants